This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Refactor setState in TodoApp #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kenotron take a peak. this is a pretty big rewrite of the todo app logic. curious if you have a preference on how this is presented, as we don't dig into it too deep during class. |
ahtee
reviewed
Mar 12, 2019
| - Note that we can't add new parameters to onClick, but we can pull information from the event target! | ||
|
|
||
| 4. Call `_onAdd` from the submit button | ||
| 4. Assign `_onAdd` as the `onClick` event handler for the submit button. |
|
would love to dive back into this and use hooks. Even better than class based state. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
setStatefunction calls inTodoAppto use a state change function instead of state object as per React conventions.Also added some clarifications in 1-07 excercise readme and removed a line that's no longer applicable